Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: npm packages using js_library #652

Merged
merged 1 commit into from
Jul 18, 2024
Merged

test: npm packages using js_library #652

merged 1 commit into from
Jul 18, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jul 18, 2024

Changes are visible to end-users: no

Test plan

  • New test cases added

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Jul 18, 2024 •
edited
Loading

Test

All tests were cache hits

81 tests (100.0%) were fully cached saving 12s.

Buildifier      Format

@jbedard jbedard requested a review from thesayyn July 18, 2024 05:49
@jbedard jbedard enabled auto-merge (squash) July 18, 2024 05:49
@jbedard jbedard merged commit 4fb7825 into aspect-build:main Jul 18, 2024
22 of 23 checks passed
@jbedard jbedard deleted the js_library-pkg branch July 18, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @thesayyn