Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert forward slashes to backslashes for protoc plugins on Windows. #668

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: convert forward slashes to backslashes for protoc plugins on Windows. #668

wants to merge 3 commits into from
+12 −3

Commits on Nov 4, 2024

  1. fix: convert forward slashes to backslashes for protoc plugins on Win… 

    …dows.

Fixes aspect-build#667

This takes the approach used [elsewhere in rules_ts](https://github.com/aspect-build/rules_ts/blob/da284adac1fcb6bd9da81ce5d4b3e29660ecface/ts/private/ts_project.bzl#L80) to detect if we are building on Windows. protoc will fail to call into the plugins if they are expressed to protoc as forward-slash paths.
    @willjschmitt
    willjschmitt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2a3fb68 View commit details
    Browse the repository at this point in the history

  2. fixup: remove unused ctx variable

    @willjschmitt
    willjschmitt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0202e15 View commit details
    Browse the repository at this point in the history

  3. fixup: add new dep on platform_utils to bzl_library target

    @willjschmitt
    willjschmitt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    461bb13 View commit details
    Browse the repository at this point in the history