Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce array array operations #676

Merged
merged 1 commit into from
Aug 29, 2024
Merged

perf: reduce array array operations #676

merged 1 commit into from
Aug 29, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Aug 29, 2024

Reduce unnecessary and duplicate array loops and concatenating.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Aug 29, 2024 •
edited
Loading

Test

All tests were cache hits

85 tests (100.0%) were fully cached saving 10s.

Buildifier      Format

gregmagolan
gregmagolan approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks right to me

@jbedard jbedard marked this pull request as ready for review August 29, 2024 16:13
@jbedard jbedard merged commit ed84211 into aspect-build:main Aug 29, 2024
23 checks passed
@jbedard jbedard deleted the loopers branch August 29, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @gregmagolan