generated from bazel-contrib/rules-template
-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always declare ts_project_rule as primary ts_project target #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bcc84e
to
e7c5703
Compare
dzbarsky
reviewed
Oct 7, 2024
dzbarsky
reviewed
Oct 7, 2024
e7c5703
to
b86d9ec
Compare
b86d9ec
to
26603eb
Compare
dzbarsky
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, this looks simpler and makes our life better as well. We're trying this internally, will let you know
Yeah, this is nice that the macro produce the same rule type as it name. 👍 |
gregmagolan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
ts_project
macro produce more consistent underlying targets. The{name}
target will now be ats_project_rule
100% of the time. The only conditional logic is the the same as today: the addition of{name}_types
,{name}_typecheck
,{name}_typecheck_test
.We can maybe think of adding those 3 extra targets 100% of the time in the future (or maybe only doing
{name}_types
100% of the time and adding the test only when{name}
will not run tsc?).Changes are visible to end-users: no
Test plan