Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not include tsconfig inputs in ts_project outputs #755

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 8, 2025

Transitive tsconfig files/dependencies are propagated as their own TsConfigInfo dependency tree. Those tsconfig files/dependencies should never be outputs of ts_project.

Close #754


Changes are visible to end-users: yes

  • Suggested release notes appear below: no

Never include tsconfig related files and dependencies in ts_project outputs.

Test plan

  • New test cases added

Copy link

aspect-workflows bot commented Jan 8, 2025

Test

6 test targets passed

Targets
//examples/extends_chain/main:tsconfig_target_typecheck_test [k8-fastbuild] 92ms
//ts/test:outputs_tsconfig_dict_test [k8-fastbuild]                         40ms
//ts/test:outputs_tsconfig_file_test [k8-fastbuild]                         44ms
//ts/test:outputs_tsconfig_target_test [k8-fastbuild]                       37ms
//ts/test:outputs_use_dict_extending_tsconfig_target_test [k8-fastbuild]    42ms
//ts/test:outputs_use_extending_tsconfig_target_test [k8-fastbuild]         40ms

Total test execution time was 295ms. 153 tests (96.2%) were fully cached saving 15s.


Buildifier      Format

Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard enabled auto-merge (rebase) January 9, 2025 20:10
@jbedard jbedard merged commit ad6f86c into aspect-build:main Jan 9, 2025
20 checks passed
@jbedard jbedard deleted the 739-tsconfig-tsc branch January 9, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants