refactor: use pnpm to run the build-web script #1
Conversation
kormide
force-pushed
the
pnpm-prefactor
branch
4 times, most recently
from
998a91b
to
a2164a0
Compare
kormide
changed the title
client/web/webpack.config.js
Outdated
| fallback: { | ||
| path: require.resolve("path-browserify"), | ||
| util: require.resolve("util/") | ||
| } |
There was a problem hiding this comment.
I'm not sure why I had to add this when the yarn build handled this just fine.
| "@opentelemetry/resources": "^1.7.0", | ||
| "@opentelemetry/sdk-trace-base": "^1.7.0", |
There was a problem hiding this comment.
If I added some new deps here, it's because they were being depended upon directly but were actually transitive deps before pnpm.
client/build-config/src/paths.ts
Outdated
| // NOTE: use fs.realpathSync() in addition to path.resolve() to resolve | ||
| // symlinks to the real path. This is required for webpack plugins using | ||
| // `include: [...file path...]`. |
There was a problem hiding this comment.
Should we mention how this is related to using pnpm?
There was a problem hiding this comment.
I'm still not 100% sure if this is the greatest idea. I worry we'll need fixes like this all over the place.
Would be better if we found a fix specifically to help webpack work with symlinks, instead of us having to do things like this to workaround webpack not working with symlinks...
| fallback: { | ||
| path: require.resolve('path-browserify'), | ||
| util: require.resolve('util/'), | ||
| }, |
There was a problem hiding this comment.
Still not clear to be why I had to add these for pnpm.
There was a problem hiding this comment.
Something to do with redirecting imports if it's not found, which is useful for browserified node libraries (I think).
jbedard
force-pushed
the
pnpm-prefactor
branch
from
410f928
to
955cff4
Compare
jbedard
force-pushed
the
pnpm-prefactor
branch
from
955cff4
to
7fc4a13
Compare
|
I can't approve since I'm a PR author, but maybe @gregmagolan should take a look anyway. |
To break up the pnpm prefactor, the goal of this PR is to just get the
build-webscript working, which builds the main web application.