Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-deps web UI server route doesn't seem to handle slashes correctly #75

Open
vhfmag opened this issue Jun 17, 2018 · 0 comments
Open

git-deps web UI server route doesn't seem to handle slashes correctly #75

vhfmag opened this issue Jun 17, 2018 · 0 comments
Labels
bug help wanted web UI

Comments

@vhfmag
Copy link

vhfmag commented Jun 17, 2018

At the company where I work, we use some conventions around branch names, including prefixing feature branches with feat/ and bugfix branches with fix/. When I feed one of those into the UI's input and submit, a request is sent to the server and answered with a 404 code.

Despite their similarity, that probably isn't a duplicate of #74, as 422 is the code sent when the server actually receives and treats the request, but the requested commit-ish isn't found. I couldn't find any related issues.

Does anyone get the same behavior? I'm using it under Ubuntu 16.04 and Python 3.5.2.
vhfmag added a commit to vhfmag/git-deps that referenced this issue Jun 17, 2018
@vhfmag
Make /deps.json/<revspec> route accept slashes
c1b7c69 
As noted on aspiers#75, currently, the server doesn't recognize requests for /deps.json/ route for branch names with slashes (i.e. `feat/` and `fix/`). The fix is done by adding a `path:` converter to the route, as explained in http://flask.pocoo.org/docs/1.0/quickstart/#variable-rules.

Closes aspiers#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted web UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aspiers @vhfmag