Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving settings not working. #103

Closed
afragen opened this issue Nov 2, 2024 · 5 comments · Fixed by #108
Closed

Saving settings not working. #103

afragen opened this issue Nov 2, 2024 · 5 comments · Fixed by #108
Assignees
Labels
bug Something isn't working
Milestone

Comments

@afragen
Copy link
Contributor

afragen commented Nov 2, 2024

Bug Report

Description

Unable to save settings.

Environment

  • WordPress: 6.6.2
  • PHP: 8.3.11
  • Server: nginx/1.26.1
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.3.11)
  • Browser: Safari 18.0.1
  • OS: macOS
  • Theme: Twenty Twenty-Four 1.2
  • MU Plugins: None activated
  • Plugins:
    • AspireUpdate 0.5
    • Test Reports 1.2.0

Steps to Reproduce

  1. New WP installation.
  2. Go to AspireUpdate menu and page.
  3. Change some settings.
  4. Click Save Changes
    x. 🐞 Bug occurs.
    Nothing seems to happen with button click.

Expected Results

  1. ✅ What should happen.
    Expected settings to save and page to reload.

Actual Results

  1. ❌ What actually happened.
    Save Changes button doesn't seem to function.

Additional Notes

I believe this has to do with the scripts that are enqueued.
Unloading the scripts by commenting out the following line results in the correct function.

add_action( 'admin_enqueue_scripts', array( $this, 'admin_enqueue_scripts' ) );
@afragen
Copy link
Contributor Author

afragen commented Nov 2, 2024

I do see the following in the console.

An invalid form control with name='aspireupdate_settings[api_key]' is not focusable.

@afragen
Copy link
Contributor Author

afragen commented Nov 2, 2024

OK, I now see that it only works properly if Enable AspireUpdate API Rewrites is checked and a key is supplied. Then all other settings will save.

@afragen afragen closed this as completed Nov 2, 2024
@ipajen
Copy link
Collaborator

ipajen commented Nov 2, 2024

@afragen i reopen as it is a bug.
#43

It should be possible debug without rewrites are on.

  1. Click reset
  2. Click enable debug and string
  3. Click save

Nothing happens.

@ipajen ipajen reopened this Nov 2, 2024
@ipajen ipajen added the bug Something isn't working label Nov 2, 2024
@asirota asirota added this to the Phase 1 milestone Nov 3, 2024
@asirota
Copy link
Member

asirota commented Nov 3, 2024

@namithj this was marked as fixed, can you have a look and see if debugging works and can be set even if rewrite is deactivated?

@namithj
Copy link
Contributor

namithj commented Nov 3, 2024

Is this from current main branch?

This is new, will check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants