Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Text domain to AspireUpdate #41

Closed
ipajen opened this issue Oct 24, 2024 — with Slack · 2 comments
Closed

Update Text domain to AspireUpdate #41

ipajen opened this issue Oct 24, 2024 — with Slack · 2 comments
Assignees
@namithj
Labels
enhancement New feature or request
Milestone
0.5

Comments

@ipajen Slack
Copy link
Collaborator

ipajen commented Oct 24, 2024

Now the text domain is aspiredomain and it would be great if it could be AspireUpdate instead.

Even if we don’t use the plugin check there could be end users who does this and to avoid noise it could be worth fixing as who knows for future maybe this plugin could be in the Wp repo…

WordPress.WP.I18n.TextDomainMismatch

Mismatched text domain. Expected 'AspireUpdate' but got 'aspireupdate'
@namithj
Copy link
Contributor

namithj commented Oct 24, 2024

so change from all lowercase to the capitalized version. Thats a weird recommendation from plugin check!

@asirota asirota added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Oct 26, 2024
@asirota asirota added this to the 0.5 milestone Oct 26, 2024
@namithj namithj mentioned this issue Oct 28, 2024
Merged
asirota pushed a commit that referenced this issue Oct 28, 2024
@namithj
Issue Fixes (#61)
f4b21c7 
* #33

Plugin Name Change

* #36

#36
#33
#26
#13

* AP_HOST Defaults

AP_HOST Defaults

* Bug Fixes

#56
#47
#43
#42
#41

* Update class-debug.php

reword the failure to write to log file message

Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>

---------

Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>
@ipajen
Copy link
Collaborator Author

ipajen commented Oct 28, 2024

Closing as warnings above are gone now.

@ipajen ipajen closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namithj namithj

Labels
enhancement New feature or request
Projects
Project Phase 1
Status: Done
Milestone
0.5
Development

No branches or pull requests
3 participants
@asirota @namithj @ipajen