Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve I18N Issues Based on version 0.5 #104

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Improve I18N Issues Based on version 0.5 #104

merged 1 commit into from
Nov 3, 2024

Conversation

alexclassroom
Copy link
Contributor

Including zh_TW language files.

Pull Request

What changed?

Fixed the current I18N issues

Why did it change?

Making the plugin localizable means pushing it easier.

Did you fix any specific issues?

(Please tag any specific issues here...)

CERTIFICATION

By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.

@alexclassroom
Improve I18N Issues Based on version 0.5
c54a183 
Including zh_TW language files.

Signed-off-by: Alex Lion <learnwithalex@gmail.com>
@namithj
Copy link
Contributor

namithj commented Nov 3, 2024

@asirota How do we review translations?

@asirota
Copy link
Member

asirota commented Nov 3, 2024 •
edited
Loading

You can change the language for WordPress and the plugin should also change language assuming the language you switched to has been installed for the language.

https://developer.wordpress.org/advanced-administration/before-install/in-your-language/

@alexclassroom has provided Chinese (Taiwan) in this case.

@asirota
Copy link
Member

asirota commented Nov 3, 2024

This is related to issue #75 which calls for language pack support.

@namithj
Copy link
Contributor

namithj commented Nov 3, 2024

It's Mandarin / Taiwanese. How do we verify the translations.

@namithj
Copy link
Contributor

namithj commented Nov 3, 2024

Unless we know someone who knows the language the only option for a second eye is to use google translate to verify the translations. The workflow should need a second eye so that we can be certain the translations are accurate.

@asirota
Copy link
Member

asirota commented Nov 3, 2024 •
edited
Loading

Oh you mean the validity of the translation? The only way to really to do it is with another native speaker. AI could help too I guess. Or trust the translator implicitly. Beggars can't be choosers.

@namithj
Copy link
Contributor

namithj commented Nov 3, 2024

Yup, need a second eye on translations or we need to decide implicitly trust all sources right now as policy, for that we need a disclaimer.

@asirota
Copy link
Member

asirota commented Nov 3, 2024 •
edited
Loading

Also while there is a need to have as many languages as possible, there is most definitely a priority of which languages are used right now online. English makes up 49% of the internet websites and then there is a long tail of languages with these making nearly the next 50%

image

From
https://w3techs.com/technologies/overview/content_language

@alexclassroom
Copy link
Contributor Author

You don't need to review/verify my translations because I am a qualified zh_TW community localizier.
Please view my bio here.

@namithj
Copy link
Contributor

namithj commented Nov 3, 2024

Hi @alexclassroom, your's is the first translation contribution to the project, we are trying to establish some protocols on how to review, accept and deploy translations for the project for this and future contributions.

@asirota asirota closed this Nov 3, 2024
@asirota asirota reopened this Nov 3, 2024
@asirota asirota merged commit 8c201e8 into aspirepress:main Nov 3, 2024
2 checks passed
@asirota asirota self-assigned this Nov 4, 2024
@asirota asirota added the i18n Internationalization & Localization label Nov 4, 2024
@asirota asirota added this to the Phase 1 milestone Nov 4, 2024
asirota added a commit that referenced this pull request Nov 5, 2024
@asirota @namithj
@costdev @alexclassroom @sebastienserre @harikrishnanr994 @afragen
Updating Playground-ready from main (#98)
ccd03ce 
* Prevent Recursion on certain Host name patterns (#69)

---------

Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>

* Playground ready updating into main (#71)

* Update blueprint.json

Switching to default theme of 2022 to support minimum WP Playground support for WordPress version as 5.9.9

Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>

* Switching blueprint.json to 2022 theme

Signed-off-by: Alex Sirota <alex@newpathconsulting.com>

---------

Signed-off-by: Alex Sirota <alex@newpathconsulting.com>
Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>

* `Add New Plugin`: Remove 'Featured' and 'Favorites' tabs when API rewrite is enabled. (#80)

* Add class for overriding plugins screens.

* Remove unused tabs when API rewrite is enabled.

* `Add New Theme`: Remove 'Favorites' filter tab when API rewrite is enabled. (#82)

* Add class for overriding themes screens.

* Hide unsupported filters.

* Redirect unsupported filters to `theme-install.php`.

---------

Signed-off-by: Alex Sirota <alex@newpathconsulting.com>
Co-authored-by: Alex Sirota <alex@newpathconsulting.com>

* Add PHPUnit. (#87)

* Add PHPUnit scaffolding.

* Add Composer files for dependencies and test script.

* Add `.gitignore`.

* Add sample test for `Admin_Settings::get_setting()`.

* Add PHP 8.3 to the test matrix.

* Add `.cache/*` to `.gitignore`.

* Limit testing to PHP 7.4 (minimum) and 8.3 (latest).

* `Plugins Screens`: Initialize in `Controller::__construct()`. (#89)

* `Workflows`: Fix PHP version and add more workflow triggers. (#92)

* Fix PHP version.

* Add `push` and `workflow_dispatch` workflow triggers.

* `Tests`: Ensure options are not set when tests run. (#95)

* Introduce a test constant.

* Don't initialize when the tests are running.

* Use a new object for testing `Admin_Settings::get_setting()`.

* Warning when debug-aspire-update.log doesnt exist (#109)

* `Tests`: Add default coverage settings. (#97)

* Improve I18N Issues Based on version 0.5 (#104)

* Fixes Settings not getting saved when rewrites were turned off (#108)

* Add French Translation (#105)

* I18n fr fr (#113)

* Translations loading fix112 (#114)

* Add French translations. 

* load any available translations with code in the plugin

* #110 (#116)

Fixes #110

* Add nonce verification and sanitize `$_REQUEST/$_GET` values. (#115)

Signed-off-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

* Added German Translation (#111)

* added German translation

* added gitignore for .DS_Store


Signed-off-by: Harikrishnan R <harikrishnanr994@gmail.com>

* Voltron has landed. (#117)

The Voltron has landed. See if you can find where.

* `Admin Settings`: Delete all settings when the plugin is uninstalled. (#118)

* `Admin Settings`: Add multisite-safe deletion of all settings.

* Delete all settings when the plugin is uninstalled.

* add multisite support (#102)

* accidentally deleted (#124)

Fixed typo in code deleted when addressing #102

* Add `.editorconfig`. (#123)

* create zip with each new tagged release (#121)

* create zip with each new tagged release

* update .gitattributes

---------

Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>
Signed-off-by: Alex Sirota <alex@newpathconsulting.com>
Signed-off-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Signed-off-by: Harikrishnan R <harikrishnanr994@gmail.com>
Co-authored-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Alex Lion <learnwithalex@gmail.com>
Co-authored-by: Sébastien SERRE <sebastien@thivinfo.com>
Co-authored-by: Harikrishnan R <harikrishnanr994@gmail.com>
Co-authored-by: Andy Fragen <andy@thefragens.com>
asirota added a commit that referenced this pull request Nov 5, 2024
@asirota @namithj
@costdev @alexclassroom @sebastienserre @harikrishnanr994 @afragen
Continue to sync playground-ready with newest PRs on main (#129)
6845ffa 
* Prevent Recursion on certain Host name patterns (#69)

---------

Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>

* Playground ready updating into main (#71)

* Update blueprint.json

Switching to default theme of 2022 to support minimum WP Playground support for WordPress version as 5.9.9

Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>

* Switching blueprint.json to 2022 theme

Signed-off-by: Alex Sirota <alex@newpathconsulting.com>

---------

Signed-off-by: Alex Sirota <alex@newpathconsulting.com>
Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>

* `Add New Plugin`: Remove 'Featured' and 'Favorites' tabs when API rewrite is enabled. (#80)

* Add class for overriding plugins screens.

* Remove unused tabs when API rewrite is enabled.

* `Add New Theme`: Remove 'Favorites' filter tab when API rewrite is enabled. (#82)

* Add class for overriding themes screens.

* Hide unsupported filters.

* Redirect unsupported filters to `theme-install.php`.

---------

Signed-off-by: Alex Sirota <alex@newpathconsulting.com>
Co-authored-by: Alex Sirota <alex@newpathconsulting.com>

* Add PHPUnit. (#87)

* Add PHPUnit scaffolding.

* Add Composer files for dependencies and test script.

* Add `.gitignore`.

* Add sample test for `Admin_Settings::get_setting()`.

* Add PHP 8.3 to the test matrix.

* Add `.cache/*` to `.gitignore`.

* Limit testing to PHP 7.4 (minimum) and 8.3 (latest).

* `Plugins Screens`: Initialize in `Controller::__construct()`. (#89)

* `Workflows`: Fix PHP version and add more workflow triggers. (#92)

* Fix PHP version.

* Add `push` and `workflow_dispatch` workflow triggers.

* `Tests`: Ensure options are not set when tests run. (#95)

* Introduce a test constant.

* Don't initialize when the tests are running.

* Use a new object for testing `Admin_Settings::get_setting()`.

* Warning when debug-aspire-update.log doesnt exist (#109)

* `Tests`: Add default coverage settings. (#97)

* Improve I18N Issues Based on version 0.5 (#104)

* Fixes Settings not getting saved when rewrites were turned off (#108)

* Add French Translation (#105)

* I18n fr fr (#113)

* Translations loading fix112 (#114)

* Add French translations. 

* load any available translations with code in the plugin

* #110 (#116)

Fixes #110

* Add nonce verification and sanitize `$_REQUEST/$_GET` values. (#115)

Signed-off-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

* Added German Translation (#111)

* added German translation

* added gitignore for .DS_Store


Signed-off-by: Harikrishnan R <harikrishnanr994@gmail.com>

* Voltron has landed. (#117)

The Voltron has landed. See if you can find where.

* `Admin Settings`: Delete all settings when the plugin is uninstalled. (#118)

* `Admin Settings`: Add multisite-safe deletion of all settings.

* Delete all settings when the plugin is uninstalled.

* add multisite support (#102)

* accidentally deleted (#124)

Fixed typo in code deleted when addressing #102

* Add `.editorconfig`. (#123)

* create zip with each new tagged release (#121)

* create zip with each new tagged release

* update .gitattributes

* Cleanup after `.editorconfig` was added to the repository. (#126)

* Add coding standard. (#127)

* Add Coding Standard.

* Add PHPCS cache directory.

* Coding Standards: Apply PHPCBF to codebase.

* Coding Standards: Add GitHub workflow.

---------

Signed-off-by: Alex Sirota <alex@newpathconsulting.com>
Co-authored-by: Alex Sirota <alex@newpathconsulting.com>

---------

Signed-off-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>
Signed-off-by: Alex Sirota <alex@newpathconsulting.com>
Signed-off-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Signed-off-by: Harikrishnan R <harikrishnanr994@gmail.com>
Co-authored-by: Namith Jawahar <48271037+namithj@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Alex Lion <learnwithalex@gmail.com>
Co-authored-by: Sébastien SERRE <sebastien@thivinfo.com>
Co-authored-by: Harikrishnan R <harikrishnanr994@gmail.com>
Co-authored-by: Andy Fragen <andy@thefragens.com>
@ipajen
Copy link
Collaborator

ipajen commented Nov 5, 2024

@alexclassroom There is a new #polyglots slack, that you are if possible , welcome to join. https://aspirepress.org/slack/
Btw: there is some new strings to be translated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namithj namithj namithj approved these changes

@asirota asirota asirota approved these changes

Assignees

@asirota asirota

Labels
i18n Internationalization & Localization
Projects
Project Phase 1
Status: No status
Milestone
Phase 1
Development

Successfully merging this pull request may close these issues.
4 participants
@alexclassroom @namithj @asirota @ipajen