Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetEase provider #389

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Add NetEase provider #389

merged 4 commits into from
Feb 24, 2020

Conversation

HahaMango
Copy link
Contributor

Hi, I implemented a NetEase provider, also add the test code.

Hot to use:

builder.AddNetEase(options => 
{
    options.ClientId = "your client Id ";
    options.ClientSecret = "your client secret ";
});

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an OAuth provider, HTTPS needs to be used everywhere.

@HahaMango
Copy link
Contributor Author

@martincostello Yes, according to the document it's just a user name, not a mailbox, my fault. I've changed it.

@martincostello martincostello added this to the 3.1.0 milestone Feb 24, 2020
@martincostello martincostello merged commit f064daa into aspnet-contrib:dev Feb 24, 2020
@martincostello
Copy link
Member

Thanks again for your contribution @HahaMango 🎉

@martincostello
Copy link
Member

This provider is now available from NuGet.org: https://www.nuget.org/packages/AspNet.Security.OAuth.NetEase/3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants