Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Apple email claim is set for .NET Core 2 #412

Conversation

lukefulliton
Copy link
Contributor

Set the ClaimTypes.Email claim from the email claim in the JWT if it is present and an email is not received as a parameter with the sign in.

Resolves #407
This pull-request is the .NET Core 2 version of this pull-request: #411

@lukefulliton
Copy link
Contributor Author

Looks like there was an issue with the build. I will investigate.

@martincostello
Copy link
Member

Looks like there was an issue with the build. I will investigate.

I think there's a few C# 8 features in the code copied verbatim that the older SDK doesn't like.

@lukefulliton
Copy link
Contributor Author

lukefulliton commented Apr 18, 2020

I think there's a few C# 8 features in the code copied verbatim that the older SDK doesn't like.

Ah, Okay. I'll try recompiling locally with VS 2017

@lukefulliton
Copy link
Contributor Author

lukefulliton commented Apr 18, 2020

I think there's a few C# 8 features in the code copied verbatim that the older SDK doesn't like.

Yeah, I had downloaded the 2.2.106 SDK and compiled the project solution, but initially did it in VS 2019. LOL :) . The code changes to accommodate the older SDK are now pushed up.

@martincostello
Copy link
Member

Great - thanks @lukefulliton! I'll merge this and the other change a bit later on today.

Currently aiming to publish the 3.0.0 and 2.2.1 releases on Monday.

@lukefulliton
Copy link
Contributor Author

Thanks for all your help @martincostello !

@martincostello martincostello merged commit 87c3383 into aspnet-contrib:rel/2.2.1 Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants