Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom implementation of AspNet.Security.OAuth #836

Merged
merged 11 commits into from
Jun 14, 2024
Merged

Zoom implementation of AspNet.Security.OAuth #836

merged 11 commits into from
Jun 14, 2024

Conversation

softwareolatomiwa
Copy link
Contributor

Zoom implementation of AspNet.Security.OAuth

@softwareolatomiwa
Copy link
Contributor Author

Hi @martincostello
Not sure why this failed as it builds perfectly in my environment. Do you mind pointing out anything I need to do to make this pass

martincostello
martincostello reviewed Mar 3, 2024
View reviewed changes
docs/zoom.md Outdated Show resolved Hide resolved
src/AspNet.Security.OAuth.Zoom/AspNet.Security.OAuth.Zoom.csproj Outdated Show resolved Hide resolved
src/AspNet.Security.OAuth.Zoom/ZoomAuthenticationConstants.cs Outdated Show resolved Hide resolved
src/AspNet.Security.OAuth.Zoom/ZoomAuthenticationConstants.cs Outdated Show resolved Hide resolved
src/AspNet.Security.OAuth.Zoom/ZoomAuthenticationConstants.cs Outdated Show resolved Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Zoom/ZoomTests.cs Outdated Show resolved Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Zoom/ZoomTests.cs Outdated Show resolved Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Zoom/ZoomTests.cs Outdated Show resolved Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Zoom/bundle.json Outdated Show resolved Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Zoom/bundle.json Outdated Show resolved Hide resolved
martincostello
martincostello reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good now.

Can you update the table of providers in the README to add this one too please?

Can you also confirm you've tested the provider with the real Zoom service and that the OAuth integration works as expected?

AspNet.Security.OAuth.Providers.sln Outdated Show resolved Hide resolved
softwareolatomiwa and others added 2 commits March 4, 2024 14:34
@softwareolatomiwa
Copy link
Contributor Author

Updated the README as advised. Also, I confirm that the real Zoom service and the OAuth integration works.

@martincostello martincostello added this to the 8.0.1 milestone Mar 4, 2024
@martincostello martincostello merged commit 7397cb2 into aspnet-contrib:dev Jun 14, 2024
8 checks passed
@martincostello
Copy link
Member

Thanks for your contribution @softwareolatomiwa - this provider is now available as part of version 8.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees
No one assigned
Labels
new provider
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@softwareolatomiwa @martincostello