Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement some HttpRequest APIs against core #435

Merged
merged 12 commits into from
Feb 16, 2022
Merged

Implement some HttpRequest APIs against core #435

merged 12 commits into from
Feb 16, 2022

Conversation

twsouthwick
Copy link
Contributor

@twsouthwick twsouthwick commented Feb 14, 2022 •
edited
Loading

This implements most of the APIs except the request body and the collection types (i.e. headers and cookies).

This change also adds .NET 6.0 as a build target so that we can have better nullability warnings (.NET Core 3.1 is still built as well).

@twsouthwick
Implement some HttpRequest APIs against core
e5d603b 
This implements most of the APIs except the request body and the collection types (i.e. headers and cookies).
@twsouthwick
Add .NET 6.0 target for better nullability info
c3de8ba
@twsouthwick
Copy link
Contributor Author

/cc @davidfowl @pranavkm

pranavkm
pranavkm approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks fine. HttpRequest.IsLocal looks a little iffy, it would be good to get a sign off from @Tratcher before we merge it.

src/SystemWebAdapters/src/HttpRequest.cs Outdated Show resolved Hide resolved
src/SystemWebAdapters/src/SystemWebStartupFilter.cs Outdated Show resolved Hide resolved
@twsouthwick twsouthwick merged commit e8cf537 into main Feb 16, 2022
@twsouthwick twsouthwick deleted the tasou/http-request branch February 16, 2022 19:10
@twsouthwick twsouthwick mentioned this pull request Feb 16, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher left review comments

@pranavkm pranavkm pranavkm approved these changes

@davidfowl davidfowl davidfowl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twsouthwick @davidfowl @pranavkm @Tratcher