Implement HttpCookieCollection and HttpCookie #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
force-pushed
the
tasou/cookies
branch
2 times, most recently
from
0d5984e
to
1322212
Compare
Closed
22 tasks
twsouthwick
force-pushed
the
tasou/cookies
branch
from
1322212
to
459c55a
Compare
Tratcher
reviewed
Mar 29, 2022
|
After looking at framework's implementation of HttpCookieCollection again, it's actually just a collection that gets written at the end. I've updated this to do the same by hooking into the HttpResponse.OnStarting event. I've also added a couple of endpoints that manipulate cookies and they do it the same now on framework and core. This will not keep the worlds in-sync (i.e. cookies set by using the adapters with the cookies set using IResponseCookies). However, this is similar to ASP.NET framework where if you're working directly with the header, things wouldn't show up there either. |
Tratcher
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.