Skip to content
This repository has been archived by the owner on Jun 20, 2019. It is now read-only.

AspNetCoreModule needs to abort failed responses #26

Closed
Tratcher opened this issue Oct 27, 2016 · 8 comments
Closed

AspNetCoreModule needs to abort failed responses #26

Tratcher opened this issue Oct 27, 2016 · 8 comments

Comments

@Tratcher
Copy link
Member

From @Tratcher on November 19, 2015 20:2

aspnet/KestrelHttpServer#341 (comment)

If the back-end server fails while writing out the response body (after the first 8kb) and closes/resets the connection, platform handler does not correctly fail the response to the client.

For a chunked request that fails sometime before the final chunked terminator the handler mistakenly adds the missing terminator. This is problematic because it tells the client the response completed successfully. It should have just closed/reset the connection.

Content-Length responses that fail after sending 8kb just hang.

Copied from original issue: aspnet/IISIntegration#39

@Tratcher
Copy link
Member Author

From @muratg on February 8, 2016 18:26

@Tratcher is this still pending?

@Tratcher
Copy link
Member Author

I tested with private builds and the behavior has improved, but it is still intermittently incorrect, especially if only a small amount of data has been sent before the back-end connection closes.

@Tratcher
Copy link
Member Author

@rynowak, @glennc said you keep running into this as a response truncation issue?

@Tratcher
Copy link
Member Author

From @glennc on August 5, 2016 20:16

@rynowak When using IIS the problem of JSON.NET throwing on circular models is exacerbated by the ANCM not severing the connection appropriately.

I can use HTTPClient to grab data from a web api in my controller and send that to a view, and not know that anything is broken if I don't have much data. In my case it was happily showing a single result on my page, and leaving out the rest. I didn't even realize until I moved it to Linux and then I would get exceptions and the app would fail.

@Tratcher
Copy link
Member Author

From @muratg on August 17, 2016 16:42

@shirhatti Is the change not in ANCM? Why assign it back to @Tratcher

@Tratcher
Copy link
Member Author

From @shirhatti on August 17, 2016 17:41

Repro app https://github.com/shirhatti/ConnectionCloseRepro

@Tratcher
Copy link
Member Author

From @shirhatti on August 17, 2016 17:42

@muratg I'll assign it to @jhkimnew to further investigate

@shirhatti
Copy link
Contributor

Fixed in 4569d6d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants