Update OAuth endpoints, fix form un-escaping #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
force-pushed
the
tratcher/oauth
branch
from
989d285
to
c46e69a
Compare
HaoK
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#327 - our regular update of oauth endpoints. No observable behavior changes.
When manually testing I realized that #368 broke form decoding in two paces when replacing
+withThe first was fixed by #379
I've included the fix for the second one in this PR because WsFed doesn't work without it. In short, plus decoding needs to be turned on for forms parsing, we only needed to turn it off for cookies.