Skip to content

Japanese resources for MVC 5.2.4 is broken #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pgrho opened this issue Mar 16, 2018 · 14 comments
Closed

Japanese resources for MVC 5.2.4 is broken #143

pgrho opened this issue Mar 16, 2018 · 14 comments
Assignees

Comments

@pgrho
Copy link

pgrho commented Mar 16, 2018

Correct: 5.2.4-preview1

Microsoft.AspNet.Mvc.ja 5.2.4-preview1
Microsoft ASP.NET MVC 日本語リソース
このパッケージには、ASP.NET MVC の 日本語 サテライト アセンブリが含まれています。

Wrong: 5.2.4:

Microsoft.AspNet.Mvc.ja 5.2.4
!aC0MD!Microsoft ASP.NET MVC {Language} Resources 表©鷗字㌍!
!lCaXD!This package contains the {Language} satellite assemblies for ASP.NET MVC. 表©鷗字㌍ 表©!

@Eilon
Copy link
Member

Eilon commented Mar 16, 2018

@dougbu - EEP! Looks like pseudo-loc made its way into our satellite resources??

cc @mkArtakMSFT

@dougbu
Copy link
Member

dougbu commented Mar 16, 2018

Yup, looks like we uploaded the *.ja packages from the wrong directory ☹️

@Eilon
Copy link
Member

Eilon commented Mar 16, 2018

I spoke to @mkArtakMSFT and we'll get this fixed for the 5.2.5 release, which should be soon.

In the meantime you can revert back to 5.2.3 if this is blocking you.

@Eilon
Copy link
Member

Eilon commented Mar 16, 2018

@dougbu / @mkArtakMSFT - we should maybe make some adjustments in how we ship this too to prevent errors like this from happening. E.g. have all the stuff to ship be in one folder.

@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented Mar 19, 2018

Hi @pgrho. We've just released 5.2.5-preview1 release which has the issue fixed. Can you please confirm that the issues you were facing are resolved?
@Eilon, to prevents things like this from happening again we're now collecting all the packages in an automated manner. The issue which resulted in the wrong packages to be collected has been addressed so we won't hit it again.

@mkArtakMSFT mkArtakMSFT self-assigned this Mar 19, 2018
@mkArtakMSFT mkArtakMSFT added this to the 3.2.5-preview1 milestone Mar 19, 2018
@danroth27
Copy link
Member

@dougbu Should this be closed?

@mkArtakMSFT
Copy link
Member

It's marked as Done already, @danroth27. I'll just wait for confirmation from the customer before closing this.

@Eilon
Copy link
Member

Eilon commented Mar 19, 2018

@mkArtakMSFT you can close the bug when we've fixed it, and we believe we fixed it. If it's still a bug we can re-open.

@Eilon
Copy link
Member

Eilon commented Mar 19, 2018

(Bugs should represent work that is remaining for us, and no work is remaining here.)

@mkArtakMSFT
Copy link
Member

Fair enough.

@diontools
Copy link

Unfortunately, this problem has recurred in v5.2.5. v5.2.5-preview1 has no problem.

@mkArtakMSFT
Copy link
Member

Hi @diontools. Can you please share a repro project for us to investigate?

@mkArtakMSFT mkArtakMSFT reopened this May 7, 2018
@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented May 7, 2018

Actually, @diontools, can you please create a new bug with the repro steps and link this one from there? Thanks!

@diontools
Copy link

Hello @mkArtakMSFT. I created a new issue. If it is wrong, would you please correct it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants