Skip to content

Japanese resources for MVC 5.2.5 is broken #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
diontools opened this issue May 7, 2018 · 5 comments
Closed

Japanese resources for MVC 5.2.5 is broken #156

diontools opened this issue May 7, 2018 · 5 comments
Assignees
Milestone

Comments

@diontools
Copy link

This issue is recurrence of #143.

Functional impact

String in the resource is garbled.

Minimal repro steps

Nuget package issue.

Expected result

Display correct string.
v5.2.5-preview1

Microsoft ASP.NET MVC 日本語リソース

Actual result

Display garbled string.
v5.2.5

!aC0MD!Microsoft ASP.NET MVC {Language} Resources 表©鷗字㌍!

@dougbu dougbu added the bug label May 7, 2018
@mkArtakMSFT mkArtakMSFT added this to the 3.2.6 milestone May 7, 2018
@mkArtakMSFT
Copy link
Member

Hi @diontools. Thanks for reporting this issue.
This was caused by a change in our release process. We are going to address this in the 3.2.6 release. We'll release it with only this fix to unblock our customers, so it won't take long to happen.

@dougbu
Copy link
Member

dougbu commented May 7, 2018

Have bumped the versions up to 3.2.6 / 5.2.6 with 3155d17 and changeset 1698988.

@dougbu
Copy link
Member

dougbu commented May 7, 2018

@joeloff addressed the underlying issue in changeset 1698961.

Remaining work includes shoring the build process up to avoid problems with the PLOC packages going forward (including verification of the Japanese packages) and to remove manual steps.

@dougbu
Copy link
Member

dougbu commented May 11, 2018

This work is complete. Please upgrade to MVC or Web API 5.2.6. Please note some packages have not yet been indexed in the NuGet gallery.

Example updated package: https://www.nuget.org/packages/Microsoft.AspNet.Mvc/5.2.6


I'll file a separate issue about the "remaining work" on automation and verification.

@diontools
Copy link
Author

Thank you so much. It's working as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants