Skip to content

HttpResponseMessage Serialisation still breaks in .NET Core 3.0 #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aliostad opened this issue Oct 22, 2019 · 3 comments
Closed

HttpResponseMessage Serialisation still breaks in .NET Core 3.0 #263

aliostad opened this issue Oct 22, 2019 · 3 comments
Labels
3 - Done
Milestone
3.2.8

Comments

@aliostad
Copy link

This is related to https://github.com/dotnet/corefx/issues/31918 and the same repro described there breaks with .NET 3.0 but the reason appears to be different and due to not using TryAddWithoutValidation according to this.

Basic issue is that headers such as Expires: -1 are not supported while they are still prevalent.
@aliostad
Copy link
Author

tenor

@jkonecki
Copy link

This issue has been present since .NET Core 2.1!

@aliostad keeps opening new bugs after we are told the issue has been fixed. Could someone PLEASE take a look at it and sort it out once and for all?!

dougbu added a commit that referenced this issue Jul 29, 2021
@dougbu
Do not validate Expires header values
69224f8 
- #263
@dougbu dougbu mentioned this issue Jul 29, 2021
Merged
dougbu added a commit that referenced this issue Jul 29, 2021
@dougbu
[releaes/3.2.8] Get builds working again (#302)
c55dd95 
- test using netcoreapp2.1
- react to .NET Core breaking change
  - see https://docs.microsoft.com/en-us/dotnet/core/compatibility/2.1#path-apis-dont-throw-an-exception-for-invalid-characters
- suppress NU5125 warnings
  - break the build because warnings are treated as errors
- do not validate Expires header values
  - #263
@dougbu
Copy link
Member

dougbu commented Jul 29, 2021

c55dd95

@dougbu dougbu closed this as completed Jul 29, 2021
@dougbu dougbu added this to the 3.2.8 milestone Jul 29, 2021
@dougbu dougbu mentioned this issue Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - Done
Projects
None yet
Milestone
3.2.8
Development

No branches or pull requests
3 participants
@aliostad @jkonecki @dougbu