Do not use FormattedModelValue in password editor template
#136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #135 - see also PR aspnet/Mvc#7430 - add quirk switch to reverse this if necessary
dougbu
commented
Mar 3, 2018
| @@ -731,14 +731,63 @@ public void ObjectTemplateDisplaysNullDisplayTextWithNullModelAndTemplateDepthGr | |||
| public void PasswordTemplateTests() | |||
| { | |||
| Assert.Equal( | |||
| "<input class=\"text-box single-line password\" id=\"FieldPrefix\" name=\"FieldPrefix\" type=\"password\" value=\"Value\" />", | |||
| "<input class=\"text-box single-line password\" id=\"FieldPrefix\" name=\"FieldPrefix\" type=\"password\" />", | |||
There was a problem hiding this comment.
This test (well, two tests in one) and the two theories using the data set below set Model and FormattedModelValue. I left similar settings in PasswordTemplate_ReturnsInputElement_IgnoresValues() due to its narrower intent.
NTaylorMullen
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormattedModelValuein password editor template #135FormattedModelValuein password editor template Mvc#7430