Skip to content

Make subclassing DefaultBodyModelValidator more useful #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make subclassing DefaultBodyModelValidator more useful #97

wants to merge 1 commit into from

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Oct 27, 2017

@dougbu
Make subclassing DefaultBodyModelValidator more useful
89b8900 
- #9
- add `BodyModelValidatorContext` and `IBodyModelValidatorKeyBuilder`
@dnfclas
Copy link

dnfclas commented Oct 27, 2017

@dougbu,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@dougbu
Copy link
Member Author

dougbu commented Oct 31, 2017

eebbf38

@dougbu dougbu closed this Oct 31, 2017
@dougbu dougbu deleted the dougbu/extensible.defaultbodymodelvalidator.9 branch October 31, 2017 17:12
@dougbu
Copy link
Member Author

dougbu commented Oct 31, 2017

FYI this PR introduced a CA2227 violation. Will include a fix for this in PR #92.

I'm not sure why previous command-line builds, including the AppVeyor runs e.g. this one, succeeded. That is, I'm not sure why code analysis is disabled in AppVeyor builds. I'll file an issue for that general problem.

@dougbu dougbu mentioned this pull request Oct 31, 2017
Closed
@dougbu
Copy link
Member Author

dougbu commented Nov 1, 2017

Above CA2227 violation fixed with 15169a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eilon Eilon Eilon approved these changes

Assignees

@Eilon Eilon

Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @dnfclas @Eilon