Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Upgrade projects to netcoreapp3.0 #254

Merged
merged 5 commits into from
Nov 17, 2018
Merged

Upgrade projects to netcoreapp3.0 #254

merged 5 commits into from
Nov 17, 2018

Conversation

natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Nov 16, 2018

Upgrade this project to netcoreapp3.0.

Marking as wip: because this causes test failures which I'm not 100% how to fix. It looks like the tests expect the samples to have a certain TFM. cc @pakrym can you help?

Part of dotnet/aspnetcore#3754

@natemcmaster
Copy link
Contributor Author

JavaScriptSnippetTests are failing, presumably because they are trying to publish netcoreapp2.0 and 2.1 projects. Are these tests for backwards compatibility? Or should the also change to 3.0?

@pakrym
Copy link
Contributor

pakrym commented Nov 17, 2018

@muratg do we want to continue running tests against AI adapter? I don't think they realize we do this and seem to be doing fine.

@muratg
Copy link

muratg commented Nov 17, 2018

@pakrym what adapter? It's OK to disable tests to move forward with 3.0 port. What of our scenarios do these tests test?

I don't think they realize we do this and seem to be doing fine.

Let's make sure :)

@pakrym
Copy link
Contributor

pakrym commented Nov 17, 2018

We are running tests against Microsoft.ApplicationInsights.AspNetCore. We don't own the scenario anymore we were just running them during transition time to make sure things go smooth.

We might also want to stop producing Microsoft.AspNetCore.ApplicationInsights.HostingStartup package.

@natemcmaster natemcmaster changed the title wip: Upgrade projects to netcoreapp3.0 Upgrade projects to netcoreapp3.0 Nov 17, 2018
@natemcmaster
Copy link
Contributor Author

Tests pass now :)

Copy link
Contributor

@pakrym pakrym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go forward with this to unblock other tasks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants