-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
JavaScriptSnippetTests are failing, presumably because they are trying to publish netcoreapp2.0 and 2.1 projects. Are these tests for backwards compatibility? Or should the also change to 3.0? |
@muratg do we want to continue running tests against AI adapter? I don't think they realize we do this and seem to be doing fine. |
@pakrym what adapter? It's OK to disable tests to move forward with 3.0 port. What of our scenarios do these tests test?
Let's make sure :) |
We are running tests against We might also want to stop producing Microsoft.AspNetCore.ApplicationInsights.HostingStartup package. |
Tests pass now :) |
AI has it's new hosting startup here https://mseng.visualstudio.com/AppInsights/_git/StatusMonitor?path=%2FExtensions%2FExtension%2FAspNetCore.HostingStartup&version=GBmaster And it's running a lot more tests than we did: https://github.com/Microsoft/ApplicationInsights-aspnetcore/tree/develop/test/Microsoft.ApplicationInsights.AspNetCore.Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should go forward with this to unblock other tasks.
Upgrade this project to netcoreapp3.0.
Marking as wip: because this causes test failures which I'm not 100% how to fix. It looks like the tests expect the samples to have a certain TFM. cc @pakrym can you help?
Part of dotnet/aspnetcore#3754