Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in SDK features for commit hash attributes and source-link #618

Closed
natemcmaster opened this issue Mar 22, 2018 · 3 comments
Closed
Assignees
Labels
arcade cost: S Will take up to 2 days to complete
Milestone

Comments

@natemcmaster
Copy link
Contributor

MSBuild and Microsoft.NET.Sdk will soon have the ability to embed commit hashes and other source info. Once that is available, we can probably drop our own implementations of commit hash attribute generation, source link generation and others.

Currently a WIP - cref NuGet/NuGet.Client#2081, dotnet/msbuild#3063, https://github.com/tmat/repository-info/blob/master/docs/Readme.md by @tmat.

@natemcmaster
Copy link
Contributor Author

@dougbu
Copy link
Member

dougbu commented Feb 13, 2019

You mentioned dotnet/aspnetcore#7504 was part of this issue. What remains?

@natemcmaster
Copy link
Contributor Author

Delete obsolete code. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcade cost: S Will take up to 2 days to complete
Projects
None yet
Development

No branches or pull requests

2 participants