Skip to content

build casing issues with assemblies. #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HaoK opened this issue Jun 21, 2018 · 10 comments
Closed

build casing issues with assemblies. #697

HaoK opened this issue Jun 21, 2018 · 10 comments

Comments

@HaoK
Copy link
Member

HaoK commented Jun 21, 2018

It looks like occasionally dlls are renamed with slightly different lowercased names by build.cmd which was causing strange failures in MVC.Testing style functional tests that rely on finding assemblies using Ordinal.

An example:

 Directory of C:\Github\AuthSamples\samples\Options.MultiTenant\bin\Debug\netcoreapp2.2

06/21/2018  12:09 PM            16,384 Options.MultiTenant.dll
06/21/2018  12:09 PM            73,216 Options.MultiTenant.Views.dll
               2 File(s)         89,600 bytes

 Directory of C:\Github\AuthSamples\samples\Options.MultiTenant\obj\Debug\netcoreapp2.2

06/21/2018  12:09 PM            16,384 Options.MultiTenant.dll
06/21/2018  12:09 PM            73,216 Options.Multitenant.Views.dll

Notice how the obj/Debug/netcoreapp2.2 has lowercase Mutlitenant.Views.dll

cc @natemcmaster @ryanbrandenburg @javiercn

@ryanbrandenburg
Copy link
Contributor

It looks like package you're referring to is here?

@HaoK
Copy link
Member Author

HaoK commented Jun 21, 2018

Yep that's the branch with the PR that has a repro. I'm going to merge this once CI passes on the updated PR.

@HaoK
Copy link
Member Author

HaoK commented Jun 21, 2018

PR: aspnet/AuthSamples#44

@natemcmaster
Copy link
Contributor

@pranavkm @rynowak is this a known issue in the Razor compiler?

@HaoK I don't think this is the result of tools in KoreBuild. It looks like a product bug in Microsoft.NET.Sdk.Razor.

@pranavkm
Copy link
Contributor

pranavkm commented Jun 25, 2018

is this a known issue in the Razor compiler?

Nope, first I've come across this. The file name's produced from $(TargetName) - it should be the same casing for the two. Did you happen to rename the project file between builds?

@HaoK
Copy link
Member Author

HaoK commented Jun 25, 2018

No manual stuff was done @pranavkm

This is what's produced after a git clean xdf + build.cmd

@HaoK
Copy link
Member Author

HaoK commented Jun 25, 2018

Its resulting in the mvc funtional tests failing due to casing, its weird because the local fix with casing worked on my laptop, but its not working on CI: https://ci.appveyor.com/project/aspnetci/authsamples/build/1.0.122

@pranavkm
Copy link
Contributor

Looks like those test are failing due to an incorrect path:

 System.ArgumentException : The content root 'C:\projects\authsamples\Options.Multitenant' does not exist.
  Parameter name: contentRoot

@HaoK
Copy link
Member Author

HaoK commented Jun 25, 2018

Yup, @javiercn and I debugged this last week, this is failing due to the casing:

https://github.com/aspnet/Mvc/blame/dev/src/Microsoft.AspNetCore.Mvc.Testing/WebApplicationFactory.cs#L208

@natemcmaster
Copy link
Contributor

Closing as this doesn't appear to be a problem anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants