This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
Move functional tests of CORS middleware to this repo #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dougbu
commented
Dec 13, 2015
dougbu
commented
- related to MVC functional test cleanup (part 1) (ETA 12/4) Mvc#3612
dougbu
added a commit
to aspnet/Mvc
that referenced
this pull request
Dec 14, 2015
- #3612 subpart 2 of 2 - merge `ActionConstraintsWebSite`, `AntiforgeryTokenWebSite` and `ContentNegotiationWebSite` into `BasicWebSite` - remove tests depending on `ErrorReporterMiddleware` in merged sites; not used in `BasicWebSite` - delete `CompositeViewEngineWebSite`, `Microsoft.AspNet.Mvc.ViewEngines.CompositeViewEngineTest` covers cases - delete `CorsMiddlewareWebsite`, soon to be in Cors repo (see aspnet/CORS#57) - remove `SendFileMiddleware` from FilesWebSite, unused there
| using System.Threading.Tasks; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.AspNet.Cors.Infrastructure |
There was a problem hiding this comment.
It matches most of the src classes as well as the other test classes.
|
⌚ - mostly to see if we can clean up the startup code. |
dougbu
added a commit
to aspnet/Mvc
that referenced
this pull request
Dec 15, 2015
- #3612 subpart 2 of 2 - merge `ActionConstraintsWebSite`, `AntiforgeryTokenWebSite` and `ContentNegotiationWebSite` into `BasicWebSite` - remove tests depending on `ErrorReporterMiddleware` in merged sites; not used in `BasicWebSite` - delete `CompositeViewEngineWebSite`, `Microsoft.AspNet.Mvc.ViewEngines.CompositeViewEngineTest` covers cases - delete `CorsMiddlewareWebsite`, soon to be in Cors repo (see aspnet/CORS#57) - remove `SendFileMiddleware` from FilesWebSite, unused there
…not_ firing and forgetting - PR comments
|
🆙📅 (Startup code greatly cleaned up. Works here though it doesn't appear like it'll work for MVC.) |
| public CorsTestFixture() | ||
| { | ||
| var builder = new WebHostBuilder().UseStartup<TStartup>(); | ||
| _server = new TestServer(builder); |
There was a problem hiding this comment.
Couldn't find a TestServer.Create<TServer> method so I did this two-step instead.
There was a problem hiding this comment.
Much better anyways. We're changing all of the hosting APIs 😄 Stay tuned!
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.