This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Restore and obsolete the CompactOnMemoryPressure property #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Jul 7, 2017
| @@ -11,6 +11,9 @@ public class MemoryCacheOptions : IOptions<MemoryCacheOptions> | |||
| { | |||
| public ISystemClock Clock { get; set; } | |||
|
|
|||
| [Obsolete("This is obsolete and will be removed in a future version.")] | |||
| public bool CompactOnMemoryPressure { get; set; } = true; | |||
There was a problem hiding this comment.
Want to change the default to false? :-) we don't do it anymore.
There was a problem hiding this comment.
Depends on how much of this we want to keep the same as before. Doesn't really matter either way.
JunTaoLuo
force-pushed
the
johluo/restore-compactonmemorypressure
branch
from
8a78cc3
to
3b45440
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #320
Do we need a fwlink for this?