Skip to content
This repository has been archived by the owner on Dec 8, 2018. It is now read-only.

Fix cross appdomain exception #318

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Fix cross appdomain exception #318

merged 1 commit into from
Jul 25, 2016

Conversation

BrennanConroy
Copy link
Member

@BrennanConroy
Copy link
Member Author

@davidfowl @pranavkm

return logger;
}

#if NET451
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this type be #if NET451?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move the #ifdef to the top of the class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, that's fine

@pranavkm
Copy link
Contributor

:shipit:

@BrennanConroy
Copy link
Member Author

🆙 📅
Looks like there was an issue with not using ObjectHandle

@pranavkm
Copy link
Contributor

:shipit: again.

@BrennanConroy BrennanConroy merged commit 496d94b into dev Jul 25, 2016
@BrennanConroy BrennanConroy deleted the brecon/appdomain branch July 25, 2016 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants