Fix excluded files and folder deletion triggers

[victorhurdugaci]

Fixes #90, https://github.com/aspnet/dotnet-watch/issues/93

• Bugfix: Trigger on new project.json file structure
• Bugfix: Trigger on folder deletion
• Add test for folder deletion

Please review @moozzyk @kichalla @ajaybhargavb

[ajaybhargavb]

Should this be nested?

[victorhurdugaci]

That's a good question, maybe you have an answer. So this new project model has two sets of properties: the old ones and the new ones.

1. Can you have both of them set at the same time?
2. Does having one set mean ignore the other one?
3. Which one takes priority because I see that the new properties are null by default if not set but the old ones have default values if not set

[ajaybhargavb]

Can you have both of them set at the same time? Does having one set mean ignore the other one?

Yes. The new ones will take priority.

Which one takes priority because I see that the new properties are null by default if not set but the old ones have default values if not set

When nothing is set, the default of old schema is used.

[ajaybhargavb]

In this case, if CompileInclude is not set but EmbedInclude is set it will be ignored.
This should probably be refactored to something like this.

if (compilerOptions.CompileInclude != null)
{
    filesToWatch.AddRange(compilerOptions.CompileInclude.ResolveFiles());
}
else
{
    filesToWatch.AddRange(runtimeProject.Files.SourceFiles);
}

if (compilerOptions.EmbedInclude != null)
{
    filesToWatch.AddRange(compilerOptions.EmbedInclude.ResolveFiles());
}
else
{
    filesToWatch.AddRange(runtimeProject.Files.ResourceFiles.Values);
}

filesToWatch.AddRange(runtimeProject.Files.PreprocessSourceFiles);
filesToWatch.AddRange(runtimeProject.Files.SharedFiles);

[kichalla]

⌚

[moozzyk]

Can you have files included/excluded per configuration/framework?

[victorhurdugaci]

@ajaybhargavb this is a question for you

[ajaybhargavb]

compile and embed are part of buildOptions which can be framework/configuration specific. So yes the schema supports it. But I am not sure if it makes sense to include/exclude files for specific framework/configuration.

[moozzyk]

I think there are rare scenarios like that but I am not sure if we need to proactively address them now.

[victorhurdugaci]

Updated

[kichalla]

from me

[ajaybhargavb]

Sorry if my reply was confusing before, I meant that compilerOptions will never be null.

[ajaybhargavb]