Microsoft.Data.Sqlite: Handle non-queries in SqliteDataReader #16053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Jun 13, 2019
smitpatel
reviewed
Jun 13, 2019
|
|
||
| /// <summary> | ||
| /// Gets the value of the specified column. | ||
| /// </summary> | ||
| /// <param name="ordinal">The zero-based column ordinal.</param> | ||
| /// <returns>The value.</returns> | ||
| public override object this[int ordinal] | ||
| => _record[ordinal]; | ||
| => _record == null |
There was a problem hiding this comment.
you could use throw exception. Upto you.
There was a problem hiding this comment.
You mean like this?
=> _record?[ordinal] ?? throw new InvalidOperationException(Resources.NoData);It didn't feel ...mathematically correct since the field value could be NULL. It's not actually an issue since NULL in the database is handled very differently; it just felt like the semantics got a bit fuzzy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16044