Add Add correlation ID for DbContext…
#16290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
roji,
AndriySvyryd,
maumar,
smitpatel and
bricelam
ajcvickers
force-pushed
the
IDontCareIfTheWorldKnowsWhatMySecretsAre0626
branch
from
2407886
to
b50158d
Compare
ajcvickers
commented
Jun 26, 2019
AndriySvyryd
approved these changes
Jun 26, 2019
ajcvickers
force-pushed
the
IDontCareIfTheWorldKnowsWhatMySecretsAre0626
branch
from
b50158d
to
cb0bc1b
Compare
ajcvickers
force-pushed
the
IDontCareIfTheWorldKnowsWhatMySecretsAre0626
branch
from
cb0bc1b
to
2a3a0e1
Compare
|
Added another commit that uses these IDs are part of improving testing for interceptors with/without |
|
@AndriySvyryd Can you take another look at this--I made significant changes. |
divega
reviewed
Jul 1, 2019
AndriySvyryd
reviewed
Jul 1, 2019
AndriySvyryd
reviewed
Jul 1, 2019
AndriySvyryd
reviewed
Jul 1, 2019
| @@ -944,7 +944,7 @@ public async Task It_throws_object_disposed_exception(bool async) | |||
| await Assert.ThrowsAsync<ObjectDisposedException>(() => context.FindAsync(typeof(Random), 77).AsTask()); | |||
|
|
|||
| var methodCount = typeof(DbContext).GetMethods(BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly).Count(); | |||
| var expectedMethodCount = 42; | |||
| var expectedMethodCount = 43; | |||
AndriySvyryd
approved these changes
Jul 1, 2019
ajcvickers
force-pushed
the
IDontCareIfTheWorldKnowsWhatMySecretsAre0626
branch
from
6d7e175
to
fd698fa
Compare
AndriySvyryd
approved these changes
Jul 2, 2019
ajcvickers
force-pushed
the
IDontCareIfTheWorldKnowsWhatMySecretsAre0626
branch
from
fd698fa
to
c55ee41
Compare
ajcvickers
force-pushed
the
IDontCareIfTheWorldKnowsWhatMySecretsAre0626
branch
from
c55ee41
to
d036eb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Add correlation ID for
DbContextlike we have forDbCommandandDbConnectionBased on more feedback, now one ID and a lease number.
Fixes #16201
Better test coverage for interceptors and Diagnostics registered at the same time
Fixes #16352