Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correlation ID for DbContext like we have for DbCommand and DbConnection #16201

Closed
ajcvickers opened this issue Jun 21, 2019 · 0 comments · Fixed by #16290
Closed

Add correlation ID for DbContext like we have for DbCommand and DbConnection #16201

ajcvickers opened this issue Jun 21, 2019 · 0 comments · Fixed by #16290
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

To make it easier to correlate events to the context instance being used.
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 24, 2019
@ajcvickers ajcvickers self-assigned this Jun 24, 2019
ajcvickers added a commit that referenced this issue Jun 26, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
2407886 
…nd `DbConnection`

Fixes #16201
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 26, 2019
@ajcvickers ajcvickers mentioned this issue Jun 26, 2019
Merged
ajcvickers added a commit that referenced this issue Jun 26, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
b50158d 
…nd `DbConnection`

Fixes #16201
ajcvickers added a commit that referenced this issue Jun 29, 2019
@ajcvickers
Add Add correlation IDs for DbContext like we have for DbCommand …
cb0bc1b 
…and `DbConnection`

Based on feedback, now three IDs and a count:
* Instance ID - set for the context instance and never changed
* Pool ID - set for the pool instance and never changed
* ID -
  * Pooling: set when leased; reset when returned.
  * No pooling: same as Instance ID
* Leases
  * Pooling: A count of the number of times the context instance has been leased
  * Not pooling: zero

Fixes #16201
ajcvickers added a commit that referenced this issue Jun 29, 2019
@ajcvickers
Add Add correlation IDs for DbContext like we have for DbCommand …
2a3a0e1 
…and `DbConnection`

Based on feedback, now three IDs and a count:
* Instance ID - set for the context instance and never changed
* Pool ID - set for the pool instance and never changed
* ID -
  * Pooling: set when leased; reset when returned.
  * No pooling: same as Instance ID
* Leases
  * Pooling: A count of the number of times the context instance has been leased
  * Not pooling: zero

Fixes #16201
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
ajcvickers added a commit that referenced this issue Jul 2, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
fd698fa 
…nd `DbConnection`

Based on more feedback, now one ID and a lease number.

Fixes #16201

Better test coverage for interceptors and Diagnostics registered at the same time

Fixes #16352
ajcvickers added a commit that referenced this issue Jul 2, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
c55ee41 
…nd `DbConnection`

Based on more feedback, now one ID and a lease number.

Fixes #16201

Better test coverage for interceptors and Diagnostics registered at the same time

Fixes #16352
ajcvickers added a commit that referenced this issue Jul 2, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
d036eb8 
…nd `DbConnection`

Based on more feedback, now one ID and a lease number.

Fixes #16201

Better test coverage for interceptors and Diagnostics registered at the same time

Fixes #16352
ajcvickers added a commit that referenced this issue Jul 3, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
a5961cc 
…nd `DbConnection`

Based on more feedback, now one ID and a lease number.

Fixes #16201

Better test coverage for interceptors and Diagnostics registered at the same time

Fixes #16352
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Add Add correlation ID for DbContext… dotnet/efcore
1 participant
@ajcvickers