Query API review changes #16706
Merged
Query API review changes #16706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly moving types to different namespaces (internal or public), and a few renames. Also, checked where Cosmos and other providers were using internal types and made those pubic. Re-enabled API consistency, except for NotNull attributes (since these aren't breaking to add later.) Fixes #12084 Fixes #15107 Fixes #15695 Fixes #15796
smitpatel
reviewed
Jul 23, 2019
| @@ -22,6 +22,9 @@ namespace Microsoft.EntityFrameworkCore | |||
| /// </summary> | |||
| public static class EntityTypeExtensions | |||
| { | |||
| public static IEnumerable<IEntityType> GetConcreteDerivedTypesInclusive([NotNull] this IEntityType entityType) | |||
smitpatel
reviewed
Jul 23, 2019
smitpatel
reviewed
Jul 23, 2019
smitpatel
reviewed
Jul 23, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly moving types to different namespaces (internal or public), and a few renames.
Also, checked where Cosmos and other providers were using internal types and made those pubic.
Re-enabled API consistency, except for NotNull attributes (since these aren't breaking to add later.)
Fixes #12084
Fixes #15107
Fixes #15695
Fixes #15796