Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final review of internal code usage #15695

Closed
ajcvickers opened this issue May 12, 2019 · 0 comments · Fixed by #16706
Closed

Final review of internal code usage #15695

ajcvickers opened this issue May 12, 2019 · 0 comments · Fixed by #16706
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

ajcvickers commented May 12, 2019 •
edited
Loading

Once query is ready, we need to do a final review of internal code used by providers. Everything other than query and conventions should be in a good state, but we may as well check everything one last time when doing the work for query.
This was referenced May 12, 2019
Closed
Closed
Closed
Closed
Closed
@ajcvickers ajcvickers self-assigned this May 17, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone May 17, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 23, 2019
ajcvickers added a commit that referenced this issue Jul 23, 2019
@ajcvickers
Query API review changes
3959fd9 
Mostly moving types to different namespaces (internal or public), and a few renames.

Also, checked where Cosmos and other providers were using internal types and made those pubic.

Re-enabled API consistency, except for NotNull attributes (since these aren't breaking to add later.)

Fixes #12084
Fixes #15107
Fixes #15695
Fixes #15796
@ajcvickers ajcvickers mentioned this issue Jul 23, 2019
Merged
ajcvickers added a commit that referenced this issue Jul 23, 2019
@ajcvickers
Query API review changes
af70174 
Mostly moving types to different namespaces (internal or public), and a few renames.

Also, checked where Cosmos and other providers were using internal types and made those pubic.

Re-enabled API consistency, except for NotNull attributes (since these aren't breaking to add later.)

Fixes #12084
Fixes #15107
Fixes #15695
Fixes #15796
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Query API review changes dotnet/efcore
1 participant
@ajcvickers