API review: Obsolete ForXxx methods in favor of shorter names #16735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smitpatel @roji Ping for review. |
roji
approved these changes
Jul 26, 2019
| @@ -97,7 +97,7 @@ public static class CosmosEntityTypeBuilderExtensions | |||
| /// <param name="entityTypeBuilder"> The builder for the entity type being configured. </param> | |||
| /// <param name="name"> The name of the parent property. </param> | |||
| /// <returns> The same builder instance so that multiple calls can be chained. </returns> | |||
| public static OwnedNavigationBuilder ForCosmosToProperty( | |||
| public static OwnedNavigationBuilder ToJsonProperty( | |||
|
Now I'll go do the same for EFCore.PG... |
|
Question: is it intentional to leave the lower-level metadata API for the provider prefix? We now have IsClustered in SqlServerIndexBuilderExtensions, calling into SetSqlServerIsClustered in SqlServerIndexExtensions. |
|
@roji I left them because we didn't decide to change them and there may be different considerations. Also, I care less about the lower-level ones. However, we could create an issue to discuss with @AndriySvyryd when he is back. |
ajcvickers
force-pushed
the
PaintingTheForthBridge0724
branch
from
f377f2b to
69f8e3c
Compare
ghost
deleted the
|
@ajcvickers opened #16773 to discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16686