Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove provider prefix from low-level metadata APIs #16773

Closed
roji opened this issue Jul 26, 2019 · 2 comments
Closed

Remove provider prefix from low-level metadata APIs #16773

roji opened this issue Jul 26, 2019 · 2 comments
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Milestone
3.0.0

Comments

@roji
Copy link
Member

roji commented Jul 26, 2019

In #16686 we removed all provider prefixes from builder extension methods, but the low-level metadata APIs have been left as-is. Discuss and decide whether we want to drop the prefix there as well.
@roji roji mentioned this issue Jul 26, 2019
Merged
@ajcvickers
Copy link
Contributor

@AndriySvyryd Thoughts?

@AndriySvyryd
Copy link
Member

I think it makes even more sense for this API as collisions are very unlikely.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jul 29, 2019
@ajcvickers ajcvickers self-assigned this Jul 29, 2019
ajcvickers added a commit that referenced this issue Jul 29, 2019
@ajcvickers
Rename provider specific core metadata extensions
73cf39b 
Fixes #16773

Note going through obsolete here since this are a lot less used.
@ajcvickers ajcvickers mentioned this issue Jul 29, 2019
Merged
@ajcvickers ajcvickers added breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware labels Jul 29, 2019
ajcvickers added a commit that referenced this issue Jul 29, 2019
@ajcvickers
Rename provider specific core metadata extensions
714e6ba 
Fixes #16773

Note going through obsolete here since this are a lot less used.
@ajcvickers ajcvickers changed the title Consider removing provider prefix from low-level metadata APIs Remove provider prefix from low-level metadata APIs Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@roji roji mentioned this issue Jul 31, 2019
Closed
roji added a commit to npgsql/efcore.pg that referenced this issue Aug 6, 2019
@roji
Rename provider specific core metadata extensions
086d039 
Fixes #942
Following dotnet/efcore#16773
@roji roji mentioned this issue Aug 6, 2019
Merged
roji added a commit to npgsql/efcore.pg that referenced this issue Aug 7, 2019
@roji
Rename provider specific core metadata extensions
c277390 
Fixes #942
Following dotnet/efcore#16773
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @roji @AndriySvyryd