Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename provider specific core metadata extensions #962

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Rename provider specific core metadata extensions #962

merged 1 commit into from
Aug 7, 2019

Conversation

roji
Copy link
Member

@roji roji commented Aug 6, 2019

Fixes #942

Following dotnet/efcore#16773

YohDeadfall
YohDeadfall approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@YohDeadfall YohDeadfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except SetIsUnlogged. Maybe just SetUnlogged? It sounds more natural.

@roji
Copy link
Member Author

roji commented Aug 7, 2019

@YohDeadfall note that this is the "low-level" metadata API, not the user-facing builder extensions, so it doesn't matter much. On the user-facing API it's already called IsUnlogged like you want. Here I just followed the EF Core convention (see the SQL Server IsClustered/SetIsClustered property on indexes).

@roji roji merged commit c277390 into dev Aug 7, 2019
@roji roji deleted the MoreRenaming branch August 7, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohDeadfall YohDeadfall YohDeadfall approved these changes

@austindrenski austindrenski Awaiting requested review from austindrenski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename metadata ForNpgsql methods
2 participants
@roji @YohDeadfall