Query: Wrap up support for owned/weak entities #16995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
commented
Aug 6, 2019
|
|
||
| return lambdaBody; | ||
| internal Expression ExpandWeakEntities(SelectExpression selectExpression, Expression lambdaBody) |
There was a problem hiding this comment.
I couldn't figure out better way to do this for now.
The issue is, projectionBinding may revisit expression multiple times but ShapedQueryExpression is mutating so we have mutated on failed translation and we cannot reuse it. Hence we need to expand weak entities (introducing ShapedQueryExpression) from projection binding expression visitor.
smitpatel
commented
Aug 6, 2019
| @@ -6,8 +6,7 @@ | |||
|
|
|||
| namespace Microsoft.EntityFrameworkCore.Query | |||
| { | |||
| // issue #15285 | |||
| internal class ComplexNavigationsWeakQuerySqlServerTest : ComplexNavigationsWeakQueryTestBase<ComplexNavigationsWeakQuerySqlServerFixture> | |||
| public class ComplexNavigationsWeakQuerySqlServerTest : ComplexNavigationsWeakQueryTestBase<ComplexNavigationsWeakQuerySqlServerFixture> | |||
AndriySvyryd
approved these changes
Aug 6, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #15285
InMemory tracked by #16994