Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryRewrite: correctly handle weak/owned entities #15285

Closed
maumar opened this issue Apr 8, 2019 · 1 comment · Fixed by #16927 or #16995
Closed

QueryRewrite: correctly handle weak/owned entities #15285

maumar opened this issue Apr 8, 2019 · 1 comment · Fixed by #16927 or #16995
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Apr 8, 2019 •
edited by smitpatel
Loading

Currently weak entities are not handled properly - we lose type entity type information when we generate entity queryable for the expanded entity. In the old pipeline we keep track of them using dictionary. We can do similar thing in the new pipeline or embed the entity type information directly into expression tree
@maumar maumar self-assigned this Apr 8, 2019
@maumar maumar added this to the 3.0.0 milestone Apr 8, 2019
@maumar maumar changed the title QueryRewrite: correctly handle weak entities QueryRewrite: correctly handle weak/owned entities Apr 8, 2019
@roji roji mentioned this issue Jun 4, 2019
Merged
5 tasks
@ajcvickers ajcvickers assigned smitpatel and unassigned maumar Jun 28, 2019
This was referenced Jun 28, 2019
Closed
Closed
@ajcvickers
Copy link
Member

Note: Be sure to re-enable test disabled for #16360

@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
smitpatel added a commit that referenced this issue Jul 3, 2019
@smitpatel
Query: Move Property/Navigation binding to EntityProjection directly
ca4f174 
Support for Owned entities
Part of #15285

Also added SQL Assertion on Sqlite for LongCount
@smitpatel smitpatel mentioned this issue Jul 3, 2019
Merged
smitpatel added a commit that referenced this issue Jul 3, 2019
@smitpatel
Query: Move Property/Navigation binding to EntityProjection directly
3d44d35 
Support for Owned entities
Part of #15285

Also added SQL Assertion on Sqlite for LongCount
smitpatel added a commit that referenced this issue Jul 17, 2019
@smitpatel
Query: Add support for owned reference navigation
5284842 
Part of #15285
@smitpatel smitpatel mentioned this issue Jul 17, 2019
Merged
smitpatel added a commit that referenced this issue Jul 17, 2019
@smitpatel
Query: Add support for owned reference navigation
b9857de 
Part of #15285
smitpatel added a commit that referenced this issue Jul 17, 2019
@smitpatel
Query: Add support for owned reference navigation
119b09e 
Part of #15285
smitpatel added a commit that referenced this issue Jul 17, 2019
@smitpatel
Query: Add support for owned reference navigation
f86cbab 
Part of #15285
smitpatel added a commit that referenced this issue Jul 17, 2019
@smitpatel
Query: Add support for owned reference navigation (#16627)
a2167dc 
Part of #15285
@ajcvickers ajcvickers mentioned this issue Jul 19, 2019
Closed
@ajcvickers ajcvickers self-assigned this Jul 24, 2019
@ajcvickers ajcvickers added the verify-fixed This issue is likely fixed in new query pipeline. label Jul 24, 2019
@ajcvickers ajcvickers mentioned this issue Jul 25, 2019
Closed
smitpatel added a commit that referenced this issue Aug 3, 2019
@smitpatel
Query: Add support for owned collections
e0ecbfc 
Resolves #16620
Resolves #16392
Partially fix #15285
smitpatel added a commit that referenced this issue Aug 3, 2019
@smitpatel
Query: Add support for owned collections
8e504f2 
Resolves #16620
Resolves #16392
Partially fix #15285
@smitpatel smitpatel mentioned this issue Aug 3, 2019
Merged
smitpatel added a commit that referenced this issue Aug 3, 2019
@smitpatel
Query: Add support for owned collections (#16927)
49f9f76 
Resolves #16620
Resolves #16392
Partially fix #15285
@smitpatel smitpatel reopened this Aug 3, 2019
@smitpatel smitpatel removed the verify-fixed This issue is likely fixed in new query pipeline. label Aug 5, 2019
@ajcvickers ajcvickers mentioned this issue Aug 6, 2019
Closed
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 6, 2019
smitpatel added a commit that referenced this issue Aug 6, 2019
@smitpatel
Query: Wrap up support for owned/weak entities
2bf6e04 
Close #15285

InMemory tracked by #16994
@smitpatel smitpatel mentioned this issue Aug 6, 2019
Merged
smitpatel added a commit that referenced this issue Aug 6, 2019
@smitpatel
Query: Wrap up support for owned/weak entities (#16995)
7653f08 
Close #15285

InMemory tracked by #16994
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
3 participants
@ajcvickers @smitpatel @maumar