Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for #15686 #17272

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Add test for #15686 #17272

merged 1 commit into from
Aug 20, 2019

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Aug 20, 2019 •
edited
Loading

Log warnings when RequiredAttribute or non-nullable references are ignored.

Resolves #15686

@AndriySvyryd AndriySvyryd requested a review from smitpatel August 20, 2019 21:15
@AndriySvyryd AndriySvyryd merged commit e7acfe4 into release/3.0-preview9 Aug 20, 2019
@ghost ghost deleted the Issue15686 branch August 20, 2019 22:42
@ajcvickers ajcvickers mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divega divega divega left review comments

@smitpatel smitpatel smitpatel approved these changes

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If entity type has good FK candidate, then it should be dependent regardless of [Required]
4 participants
@AndriySvyryd @divega @ajcvickers @smitpatel