Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If entity type has good FK candidate, then it should be dependent regardless of [Required] #15686

Closed
ajcvickers opened this issue May 10, 2019 · 0 comments · Fixed by #17272
Closed

If entity type has good FK candidate, then it should be dependent regardless of [Required] #15686

ajcvickers opened this issue May 10, 2019 · 0 comments · Fixed by #17272
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Contributor

#15539 includes a case that we believe should be fixed as a bug. Specifically:

  • The convention detects [Required] (or non-nullability) on a navigation and makes the target of the navigation the principal, but that principal contains a good FK candidate property
@ajcvickers ajcvickers added this to the 3.0.0 milestone May 10, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
AndriySvyryd added a commit that referenced this issue Aug 20, 2019
@AndriySvyryd
Add test for #15686
e8774dc 
Resolves #15686
@AndriySvyryd AndriySvyryd mentioned this issue Aug 20, 2019
Merged
@AndriySvyryd AndriySvyryd added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed poachable labels Aug 20, 2019
@AndriySvyryd AndriySvyryd removed their assignment Aug 20, 2019
AndriySvyryd added a commit that referenced this issue Aug 20, 2019
@AndriySvyryd
Log warnings when RequiredAttribute or non-nullable references are ig…
346cc83 
…nored.

Resolves #15686
AndriySvyryd added a commit that referenced this issue Aug 20, 2019
@AndriySvyryd
Log warnings when RequiredAttribute or non-nullable references are ig…
498fed2 
…nored.

Resolves #15686
AndriySvyryd added a commit that referenced this issue Aug 20, 2019
@AndriySvyryd
Log warnings when RequiredAttribute or non-nullable references are ig…
e7acfe4 
…nored.

Resolves #15686
smitpatel pushed a commit that referenced this issue Aug 21, 2019
@AndriySvyryd @smitpatel
Log warnings when RequiredAttribute or non-nullable references are ig…
4358ea8 
…nored.

Resolves #15686
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Add test for #15686 dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd