Split simple partial test classes #18896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
smitpatel
reviewed
Nov 14, 2019
test/EFCore.Cosmos.FunctionalTests/Query/NorthwindMiscCosmosTest.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Nov 14, 2019
test/EFCore.Specification.Tests/Query/KeylessEntitiesTestBase.cs
Outdated
Show resolved
Hide resolved
maumar
approved these changes
Nov 15, 2019
| using Xunit; | ||
|
|
||
| #pragma warning disable RCS1202 // Avoid NullReferenceException. | ||
|
|
||
| // ReSharper disable InconsistentNaming | ||
| namespace Microsoft.EntityFrameworkCore.Query | ||
| { | ||
| public abstract partial class SimpleQueryTestBase<TFixture> | ||
| public abstract class NorthwindAggregateOperatorsQueryTestBase<TFixture> : QueryTestBase<TFixture> |
There was a problem hiding this comment.
Why are they prefixed with Northwind? Usually the test classes are named after the feature they are testing.
There was a problem hiding this comment.
Adding Query in the name is also redundant in most cases
In reply to: 346674959 [](ancestors = 346674959)
There was a problem hiding this comment.
GearsOfWarQueryTestbase 🗡 We need to determine a consistent convention to name test classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits all our "simple" tests, which are currently in a single class (split across files via partial), into separate classes.
Still TODO: set up the Northwind database exactly once for all suites. xunit supports "shared context" via the concept of test collections, but this also has an impact on parallelism. I've posted a question on stackoverflow, @AndriySvyryd @maumar any ideas on this?