-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement darc dependency flow without adopting Arcade (yet) #626
Conversation
Internal build to verify this stuff actually works: https://dev.azure.com/dnceng/internal/_build/results?buildId=56178 |
New validation build: https://dev.azure.com/dnceng/internal/_build/results?buildId=56219 |
/AzurePipelines run Extensions-ci |
Success! 1 created and queued. |
We're still getting some errors. @ryanbrandenburg is taking a look at this. |
The problem here is that KoreBuild is overwriting the global.json when the build starts. This PR introduces an ENV to avoid this behavior. |
Getting closer.
|
Meh. Failure, no error message. https://dnceng.visualstudio.com/internal/_build/results?buildId=56894&view=logs&jobId=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&taskId=be5e7cb1-b8ca-569b-a02f-a5442c8a3f8a&lineStart=11&lineEnd=18&colStart=1&colEnd=68 I'm going to start a mail thread on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me, merge once the builds pass.
Follow-up to #626 This should complete dependency flow up Extensions from our partners.
This implements publishing build assets to BAR, without adopting the Arcade SDK (see #586).
Resolves #569