Skip to content
This repository has been archived by the owner on Nov 6, 2018. It is now read-only.

Make PhysicalFile Watcher and Provider disposable #146

Merged
merged 1 commit into from
Nov 30, 2015
Merged

Make PhysicalFile Watcher and Provider disposable #146

merged 1 commit into from
Nov 30, 2015

Conversation

BrennanConroy
Copy link
Member

@BrennanConroy
Copy link
Member Author

Also, removed PhysicalFilesWatcher from PhysicalFileInfo because it wasn't used anywhere and not accessible to anyone.

@BrennanConroy
Copy link
Member Author

@Tratcher @dougbu

dougbu
dougbu reviewed Nov 26, 2015
View reviewed changes
test/Microsoft.AspNet.FileProviders.Physical.Tests/PhysicalFileProviderTests.cs
info = provider.GetFileInfo("/File.txt");
Assert.NotNull(info);
Assert.True(info.Exists);
using (var provider = new PhysicalFileProvider(Directory.GetCurrentDirectory()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like all the changes from here on are about reducing file system burden while testing i.e. releasing resources ASAP. If there's an exception to that, let me know.

@dougbu
Copy link
Member

dougbu commented Nov 26, 2015

:shipit:

Do we have Hosting, Mvc and StaticFiles follow-ups planned to add usings, now that it's useful?

@BrennanConroy
Copy link
Member Author

Not really, I took a quick look at places this is used and I can change a few tests to dispose but can't easily dispose the other ones.

@BrennanConroy BrennanConroy merged commit df56185 into dev Nov 30, 2015
@BrennanConroy BrennanConroy deleted the brecon/dispose_watcher branch November 30, 2015 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrennanConroy @dougbu @dnfclas