Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Stop adding "http://localhost:5000" to empty IServerAddressesFeatures #917

Closed
halter73 opened this issue Jan 19, 2017 · 3 comments
Closed

Stop adding "http://localhost:5000" to empty IServerAddressesFeatures #917

halter73 opened this issue Jan 19, 2017 · 3 comments
Assignees
@JunTaoLuo
Labels
3 - Done breaking-change bug
Milestone
2.0.0-preview1

Comments

@halter73
Copy link
Member

Servers such as Kestrel and HttpSysServer should define their own default listening endpoints (which will likely still listen on port 5000) so that the servers don't have to assume that a single address of "http://localhost:5000" indicates that no listening endpoint has been configured.

Here is the relevant line of code
@halter73
Copy link
Member Author

aspnet/KestrelHttpServer#1312 is Kestrel's reaction to this proposed change. The Kestrel PR can be merged first, since adding "http://localhost:5000" to IServerAddressesFeature only results in a warning.

@shirhatti
Copy link

@Tratcher Do we have an issue to react to this in HttpSysServer as well?

@Tratcher
Copy link
Member

aspnet/HttpSysServer#297

halter73 added a commit to aspnet/KestrelHttpServer that referenced this issue Jan 19, 2017
@halter73
Warn instead of throw when ignoring IServerAddressesFeature
f32058c 
- Throwing could be too much when IServerAddressesFeature URLs come from VS
- Listen on 127.0.0.1:5000 by default

aspnet/Hosting#917
@muratg muratg added this to the 2.0.0 milestone Feb 3, 2017
@JunTaoLuo JunTaoLuo mentioned this issue Mar 1, 2017
Merged
This was referenced Mar 3, 2017
Open
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done breaking-change bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
5 participants
@halter73 @muratg @Tratcher @JunTaoLuo @shirhatti