Cross-compile Windows Services hosting package #1189

henkmollema · 2017-08-28T08:30:35Z

Cross-compile Microsoft.AspNetCore.Hosting.WindowsServices for .NET 4.6.1 and .NET Core 2.0.

I had the use the .NET Core MyGet feed as the ServiceBase API is only available in version 4.5.0-*. Perhaps the package in the ASP.NET Core MyGet feed can be updated as well?

Resolves #904

/cc @muratg @JunTaoLuo

henkmollema · 2017-08-28T11:41:01Z

build/dependencies.props

@@ -13,5 +13,6 @@
    <SerilogExtensionsLoggingVersion>1.4.0</SerilogExtensionsLoggingVersion>
    <SerilogFileSinkVersion>3.2.0</SerilogFileSinkVersion>
    <SystemReflectionMetadataVersion>1.5.0-*</SystemReflectionMetadataVersion>
+    <SystemServiceProcessVersion>4.5.0-*</SystemServiceProcessVersion>


Should we specify the package name completely? E.g. SystemServiceProcessServiceControllerVersion. If this setting is desired/necessary at all.

Should we specify the package name completely?

Either way is fine. I'll be deleting this file soon anyways as we move to a system called "lineups" to manage our package versions.

Any reason you need 4.5.0-* specifically? Or will 4.4.0 work?

cref https://github.com/aspnet/Universe/blob/dev/build/dependencies.props#L114

Yeah, I saw a PR of you coming by where you implemented that. Figured it would be fine.

I've used the 4.5.0 packages because the API was added in .NET Core 2.1: dotnet/corefx#22920. I thought this maps to 4.5.0-* packages of the runtime.

Seconded, it's easier if this can be 4.4.0, then we'll update to 4.5.0 at a later date in all repos at once.

The 4.4.0 package only has a few types from System.ServiceProcess.* namespace. 4.5.0 adds more. Which version we need will depends which API is actually referenced from hosting. I haven't looked closely at what we use. If we need 4.5.0 that's no problem, we just need to setup our internal build processes to start using new packages from the corefx team.

This package uses ServiceBase, which was added in .NET Core 2.1.

Good to know. Then yes, we'll need the 4.5.0 version of the package.

Tratcher · 2017-08-28T16:42:27Z

NuGet.config

@@ -2,6 +2,7 @@
 <configuration>
  <packageSources>
    <clear />
+    <add key="dotnet-core" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" />


We don't add these feeds directly, we mirror the packages to our feed. @ryanbrandenburg

Yeah, System.ServiceProcess.ServiceController is already being mirrored to aspnetcore-ci-dev.

natemcmaster · 2017-08-28T16:51:07Z

Talked with @Tratcher. It sounds like .NET Core 2.0 doesn't have an implementation of this API yet. We haven't started building for .NET Core 2.1 yet, so this may need to wait.

henkmollema · 2017-08-28T16:54:16Z

I see. Feel free to ping me if we target .NET Core 2.1 and you want me to update this PR. 😄

ryanbrandenburg · 2017-08-28T16:50:21Z

NuGet.config

@@ -2,6 +2,7 @@
 <configuration>
  <packageSources>
    <clear />
+    <add key="dotnet-core" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" />


Yeah, System.ServiceProcess.ServiceController is already being mirrored to aspnetcore-ci-dev.

ryanbrandenburg · 2017-08-28T16:52:35Z

build/dependencies.props

@@ -13,5 +13,6 @@
    <SerilogExtensionsLoggingVersion>1.4.0</SerilogExtensionsLoggingVersion>
    <SerilogFileSinkVersion>3.2.0</SerilogFileSinkVersion>
    <SystemReflectionMetadataVersion>1.5.0-*</SystemReflectionMetadataVersion>
+    <SystemServiceProcessVersion>4.5.0-*</SystemServiceProcessVersion>


Seconded, it's easier if this can be 4.4.0, then we'll update to 4.5.0 at a later date in all repos at once.

natemcmaster · 2017-08-28T17:00:00Z

Ok. I'm going to assign this PR to @JunTaoLuo for now so we can follow up on it later. We'll hold off merging till we can build against .NET Core 2.1.

Blocked on https://github.com/aspnet/Coherence-Signed/issues/657

JunTaoLuo · 2017-08-28T17:56:25Z

We shouldn't be cross-compiling here. We should wait for 2.1 where the ServiceBase API is available. This was why I was asking about when we are taking the new runtime last week.

henkmollema · 2017-08-28T17:57:36Z

How would we get access to the ServiceBase API? Will it be part of .NET Standard 2.1?

natemcmaster · 2017-08-28T18:01:43Z

.NET Standard 2.1

There are no plans for this AFAIK, however the API surface should be available when you target netcoreapp2.1

henkmollema · 2017-08-28T18:02:20Z

I see, but does that mean we drop .NET 4.6.1?

JunTaoLuo · 2017-08-28T18:06:31Z

Ah I mis-spoke, I meant we will need use netcoreapp2.1, not netcoreapp2.0. We plan to have it available for both core and framework.

henkmollema · 2017-08-28T18:07:15Z

That makes sense, figured we need that. I was already looking for netcoreapp2.1 but could not find it in the ASP.NET repos 😄

Tratcher · 2017-09-14T22:00:31Z

We should also update the ServiceBase sample for the new Generic Host.

Hosting/samples/GenericHostSample/ServiceBaseLifetime.cs

Line 1 in ae9da92

#if NET461

And add a sample for the current RunAsService.

Tratcher · 2017-10-25T21:46:21Z

Waiting on https://github.com/dotnet/designs/blob/d8c7b4a7b0a88fe83db1e7778df43574103f0a06/compat-pack/compat-pack.md

JunTaoLuo · 2017-10-25T22:28:15Z

FYI The current eta is for middle of November.

Tratcher · 2017-11-17T12:55:06Z

https://www.nuget.org/packages/System.ServiceProcess.ServiceController/4.5.0-preview1-25914-04

henkmollema · 2017-11-17T14:35:55Z

@Tratcher I've updated with the new preview package of System.ServiceProcess.ServiceController. I've cross-compiled with .NET Standard 2.0 instead of .NET Core. Does that makes sense? Or should we target .NET Core instead.

Tratcher · 2017-11-17T16:16:00Z

netstandard2.0 is preferred wherever possible.

JunTaoLuo

The changes are correct and is ready to merge. However, there's a few infrastructure reactions I need to make (e.g. ingestion of system packages need to be marked in our Universe builds).

JunTaoLuo · 2017-11-20T23:46:52Z

Merged in e03c6a7. Thanks @henkmollema for the contribution!

henkmollema · 2017-11-21T08:44:17Z

🎉

dnfclas added the cla-already-signed label Aug 28, 2017

henkmollema commented Aug 28, 2017

View reviewed changes

Tratcher requested a review from natemcmaster August 28, 2017 16:41

Tratcher reviewed Aug 28, 2017

View reviewed changes

Tratcher requested a review from ryanbrandenburg August 28, 2017 16:43

ryanbrandenburg suggested changes Aug 28, 2017

View reviewed changes

natemcmaster assigned JunTaoLuo Aug 28, 2017

natemcmaster added the blocked Blocked label Aug 28, 2017

ghost removed the cla-already-signed label Nov 14, 2017

Cross-compile Windows Services hosting package

689be7f

Tratcher added 1 - Ready and removed blocked Blocked labels Nov 17, 2017

Tratcher added this to the 2.1.0 milestone Nov 17, 2017

JunTaoLuo approved these changes Nov 17, 2017

View reviewed changes

JunTaoLuo mentioned this pull request Nov 20, 2017

Update ServiceController version for netstandard support aspnet/Universe#660

Merged

JunTaoLuo closed this Nov 20, 2017

henkmollema deleted the crosscompile-windowsservices branch November 21, 2017 08:44

Tratcher mentioned this pull request Feb 28, 2018

host.RunAsService() not found #1338

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cross-compile Windows Services hosting package #1189

Cross-compile Windows Services hosting package #1189

henkmollema commented Aug 28, 2017 •

edited

Loading

henkmollema Aug 28, 2017

natemcmaster Aug 28, 2017

henkmollema Aug 28, 2017 •

edited

Loading

ryanbrandenburg Aug 28, 2017

natemcmaster Aug 28, 2017

henkmollema Aug 28, 2017

natemcmaster Aug 28, 2017

Tratcher Aug 28, 2017

ryanbrandenburg Aug 28, 2017

natemcmaster commented Aug 28, 2017

henkmollema commented Aug 28, 2017

ryanbrandenburg Aug 28, 2017

ryanbrandenburg Aug 28, 2017

natemcmaster commented Aug 28, 2017 •

edited

Loading

JunTaoLuo commented Aug 28, 2017

henkmollema commented Aug 28, 2017 •

edited

Loading

natemcmaster commented Aug 28, 2017

henkmollema commented Aug 28, 2017 •

edited

Loading

JunTaoLuo commented Aug 28, 2017

henkmollema commented Aug 28, 2017

Tratcher commented Sep 14, 2017

Tratcher commented Oct 25, 2017

JunTaoLuo commented Oct 25, 2017

Tratcher commented Nov 17, 2017

henkmollema commented Nov 17, 2017

Tratcher commented Nov 17, 2017

JunTaoLuo left a comment

JunTaoLuo commented Nov 20, 2017

henkmollema commented Nov 21, 2017

Cross-compile Windows Services hosting package #1189

Cross-compile Windows Services hosting package #1189

Conversation

henkmollema commented Aug 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henkmollema Aug 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

natemcmaster commented Aug 28, 2017

henkmollema commented Aug 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

natemcmaster commented Aug 28, 2017 • edited Loading

JunTaoLuo commented Aug 28, 2017

henkmollema commented Aug 28, 2017 • edited Loading

natemcmaster commented Aug 28, 2017

henkmollema commented Aug 28, 2017 • edited Loading

JunTaoLuo commented Aug 28, 2017

henkmollema commented Aug 28, 2017

Tratcher commented Sep 14, 2017

Tratcher commented Oct 25, 2017

JunTaoLuo commented Oct 25, 2017

Tratcher commented Nov 17, 2017

henkmollema commented Nov 17, 2017

Tratcher commented Nov 17, 2017

JunTaoLuo left a comment

Choose a reason for hiding this comment

JunTaoLuo commented Nov 20, 2017

henkmollema commented Nov 21, 2017

henkmollema commented Aug 28, 2017 •

edited

Loading

henkmollema Aug 28, 2017 •

edited

Loading

natemcmaster commented Aug 28, 2017 •

edited

Loading

henkmollema commented Aug 28, 2017 •

edited

Loading

henkmollema commented Aug 28, 2017 •

edited

Loading