This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Add test for SIGTERM functionality #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
reviewed
Nov 3, 2016
| { | ||
| "version": "1.1.0-*", | ||
| "dependencies": { | ||
| "Microsoft.AspNetCore.Server.Kestrel": "1.1.0-*", |
pakrym
force-pushed
the
pakrym/sigterm-test
branch
2 times, most recently
from
c04b368 to
f6fb717
Compare
|
|
||
| throw new Exception($"Project root could not be found using {applicationBasePath}"); | ||
| } | ||
|
|
| <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.Props" Condition="'$(VSToolsPath)' != ''" /> | ||
| <PropertyGroup Label="Globals"> | ||
| <ProjectGuid>fc578f4e-171c-4f82-b301-3abf6318d082</ProjectGuid> | ||
| <RootNamespace>Microsoft.AspNetCore.Hosting.FunctionalTests</RootNamespace> |
There was a problem hiding this comment.
Run Dougs script to clean this up
There was a problem hiding this comment.
Shared version was out-of-date. I fixed that…
pakrym
force-pushed
the
pakrym/sigterm-test
branch
from
f6fb717 to
02dc39e
Compare
pakrym
force-pushed
the
pakrym/sigterm-test
branch
from
02dc39e to
4e7de6a
Compare
Tratcher
reviewed
Nov 4, 2016
| deployer.Deploy(); | ||
|
|
||
| // Wait for application to start | ||
| System.Threading.Thread.Sleep(1000); |
There was a problem hiding this comment.
can you query the HostProcess to see if it's started? Why was the delay needed?
There was a problem hiding this comment.
Delay is to make sure hosting started IServer.
|
|
||
| SendSIGINT(deployer.HostProcess.Id); | ||
|
|
||
| deployer.HostProcess.WaitForExit(); |
There was a problem hiding this comment.
Is this going to make the test hang if something goes wrong? Any way to timeout here?
|
|
||
| public void Start<TContext>(IHttpApplication<TContext> application) | ||
| { | ||
| _serverEvent.Set(); |
There was a problem hiding this comment.
There's no guarantee Start will be called if there are other startup errors.
There was a problem hiding this comment.
Then process would be killed with timeout.
| "Microsoft.Extensions.Configuration": "1.1.0-*", | ||
| "Microsoft.Extensions.Configuration.CommandLine": "1.1.0-*", | ||
| "Microsoft.Extensions.Logging.Console": "1.1.0-*", | ||
| "Microsoft.Net.Http.Headers": "1.1.0-*" |
| "version": "1.1.0-*", | ||
| "dependencies": { | ||
| "Microsoft.AspNetCore.Hosting": "1.1.0-*", | ||
| "Microsoft.AspNetCore.WebUtilities": "1.1.0-*", |
Tratcher
reviewed
Nov 4, 2016
| } | ||
| }, | ||
| "tools": { | ||
| "Microsoft.AspNetCore.Server.IISIntegration.Tools": "1.0.0-preview2-final" |
Tratcher
reviewed
Nov 4, 2016
| }, | ||
| "publishOptions": { | ||
| "include": [ | ||
| "web.config" |
Tratcher
approved these changes
Nov 4, 2016
muratg
approved these changes
Nov 8, 2016
|
@pranavkm FYI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tratcher