Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

KeyValueAccumulator performance improvements #368

Closed
davidfowl opened this issue Aug 12, 2015 · 3 comments
Closed

KeyValueAccumulator performance improvements #368

davidfowl opened this issue Aug 12, 2015 · 3 comments
Assignees
@Tratcher
Labels
3 - Done Perf
Milestone
1.0.0

Comments

@davidfowl
Copy link
Member

  • It allocates 2 dictionaries
  • It should probably be a struct
@glennc glennc added the Perf label Aug 13, 2015
@glennc glennc added this to the 1.0.0 backlog milestone Aug 13, 2015
@davidfowl
Copy link
Member Author

Even better would be to make the KeyValueAccumulator a call back model so there was 0 allocation (besides the delegate 😄 )

This was referenced Sep 23, 2015
Closed
Closed
@muratg muratg modified the milestones: Backlog, 1.0.0 backlog Dec 11, 2015
@muratg
Copy link

muratg commented Dec 11, 2015

If you have any proof of large perf issues with this, bring it back

@benaadams
Copy link
Contributor

@muratg this was completed in #411 (comment)

@davidfowl davidfowl modified the milestones: 1.0.0, Backlog May 30, 2016
@davidfowl davidfowl assigned davidfowl and Tratcher and unassigned davidfowl May 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
3 - Done Perf
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
5 participants
@davidfowl @glennc @benaadams @muratg @Tratcher