ResponseCookiesFeature Allocates when unused

[benaadams]

Resolved by: #675

[muratg]

Investigation

[davidfowl]

@muratg dude label the bugs..

[muratg]

This doesn't seem to have a lot of benefits.

[benaadams]

@muratg I would suggest it is absurd though...

So 48MB per 1M requests is being unnecessarily allocated so that in a response where I set cookies on the server (perhaps a login authentication) it can get a StringBuilder from a pool to set the cookie.

Putting it in context: if per page the average number of requests is 100 and say best case for setting cookie ratio: go to login page, login, see another page. 200 requests allocating 9.6kB for this request feature so that one request can save a little on string concat?

Which is very doubtfully going to be a saving of 9.6kB... 😞

[benaadams]

Since you don't like the lazy init approaches, just drop all the allocations entirely? #699