This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Move RequestIdentifierFeature to HttpContext #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @benaadams, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
This was referenced Oct 15, 2015
| _features, | ||
| () => new HttpRequestIdentifierFeature()); | ||
| } | ||
| set |
There was a problem hiding this comment.
This setter is never used, correct? Remove it.
There was a problem hiding this comment.
Removed, squished
|
|
after my minor comment.
Rebased aspnet#435 Allow lazier instantiation Expose TraceIdentifier on Httpcontext Also resolves aspnet#412 Add tests
benaadams
force-pushed
the
move-request-identifier
branch
from
09e2da1 to
e01a05d
Compare
|
Applied feedback, squished |
Tratcher
added a commit
that referenced
this pull request
Oct 15, 2015
Expose TraceIdentifier on Httpcontext
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #435
Allow lazier instantiation
Expose TraceIdentifier on Httpcontext
Also resolves #412
Add tests